Remove systemPropertiesOverrideTest from 8.19
#137611
Merged
+11
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests relate to system properties set only in serverless Elasticsearch so there's no need for them in the `8.19` branch. Moreover, as with elastic#137492, this extra Gradle task forces every developer to make an extra choice when running tests in `:server`. This commit removes the unnecessary tests and the corresponding Gradle task.
DaveCTurner
added
>test
elasticsearchmachine
added
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Sec, I just realised I should also remove the serverless-only branches that these tests are testing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests relate to system properties set only in serverless
Elasticsearch so there's no need for them in the
8.19branch.Moreover, as with #137492, this extra Gradle task forces every developer
to make an extra choice when running tests in
:server. This commitremoves the unnecessary tests and the corresponding Gradle task.